1434-docker-compose - backend selection on startup #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desmax74
force-pushed
the
1434-docker-compose-split
branch
from
d4aabc2 to
fda5dae
Compare
desmax74
force-pushed
the
1434-docker-compose-split
branch
2 times, most recently
from
d956f52 to
831865e
Compare
lumjjb
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
LGTM - could you change the make file for make start-service to default to inmemory command? also, would be great to make a change to https://github.com/guacsec/guac-docs/blob/main/setup.md as well! Thanks
desmax74
force-pushed
the
1434-docker-compose-split
branch
from
e24c6bf to
32e144e
Compare
desmax74
force-pushed
the
1434-docker-compose-split
branch
from
32e144e to
9367618
Compare
Signed-off-by: desmax74 <[email protected]>
desmax74
force-pushed
the
1434-docker-compose-split
branch
from
9367618 to
cb4bafc
Compare
mihaimaruseac
approved these changes
Oct 28, 2023
dejanb
pushed a commit
to trustification/guac
that referenced
this pull request
Nov 6, 2023
Signed-off-by: desmax74 <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
See: #1434
This PR enable the startup of guac with docker compose choosing the backend
In memory docker compose -f docker-compose.yml -f container_files/mem.yaml up
Arango docker compose -f docker-compose.yml -f container_files/arango.yaml up
Ent docker compose -f docker-compose.yml -f container_files/ent.yaml up
Neo4j docker compose -f docker-compose.yml -f container_files/neo4j.yaml up
PR Checklist
-sflag togit commit.make generatehas been runcollectsubprotobuf has been changed,make protohas been run