Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Guacone to ingest json.bz2 files #1395

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Enable Guacone to ingest json.bz2 files #1395

merged 1 commit into from
Oct 18, 2023

Conversation

desmax74
Copy link
Contributor

@desmax74 desmax74 commented Oct 12, 2023 •
edited
Loading

Description of the PR

Enable Guacone to ingest compressed json files with bz2 format

Currently Guacone can't ingest compressed json files with bz2 format

guacone collect files yourfile.json.bz2

This PR solve this limitation

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@desmax74 desmax74 force-pushed the guacone-bz2 branch 2 times, most recently from dc4f7e5 to 91c2641 Compare October 12, 2023 15:26
@desmax74 desmax74 marked this pull request as ready for review October 12, 2023 15:51
@desmax74 desmax74 requested a review from jeffmendoza as a code owner October 12, 2023 15:51
@desmax74 desmax74 changed the title Add Guacone collect files json.bz2 capability Enable Guacone to collect files json.bz2 Oct 12, 2023
@desmax74 desmax74 changed the title Enable Guacone to collect files json.bz2 Enable Guacone to ingest json.bz2 files Oct 12, 2023
@desmax74 desmax74 force-pushed the guacone-bz2 branch 4 times, most recently from 24f9b22 to b666da7 Compare October 16, 2023 07:00
@desmax74 desmax74 force-pushed the guacone-bz2 branch 2 times, most recently from 5debfe9 to 32bb839 Compare October 18, 2023 07:09
@kodiakhq kodiakhq bot merged commit 8daf872 into guacsec:main Oct 18, 2023
9 checks passed
@desmax74 desmax74 deleted the guacone-bz2 branch October 19, 2023 08:51
mrizzi pushed a commit to mrizzi/guac that referenced this pull request Oct 25, 2023
@desmax74 @mrizzi
Add Guacone collect files json.bz2 capability (guacsec#1395)
758da6c 
Signed-off-by: desmax74 <[email protected]>
dejanb pushed a commit to trustification/guac that referenced this pull request Oct 26, 2023
@desmax74 @dejanb
Add Guacone collect files json.bz2 capability (guacsec#1395)
789d499 
Signed-off-by: desmax74 <[email protected]>
@mihaimaruseac mihaimaruseac mentioned this pull request Feb 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanb dejanb dejanb left review comments

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza jeffmendoza is a code owner

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desmax74 @dejanb @mihaimaruseac @pxp928