Enable path to decode encrypted features #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vazarkevych, could you have a look at this PR and the underlying issue, please? |
vazarkevych
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with responses containing
encryptedFeatures.With encryption enabled, no features can be found inside the
FeaturesViewModel.The problem can be reproduced by checking for the existence of decoded features in all
FeaturesViewModelTests.To pass the tests again I added a check if the list of unencrypted features
isEmptyto enable the pah for encrypted features in this case.There is the same
isNullOrEmpty()check int the Kotlin SDK at https://github.com/growthbook/growthbook-kotlin/blob/8e693071a63194518ef074056d40f68108b7a7a2/GrowthBook/src/commonMain/kotlin/com/sdk/growthbook/features/FeaturesViewModel.kt#L102.I was also wondering if the server response should even contain
features: {}in case of enable encryption and this lead to the problem?Sidenote: We have a similar problem with the Kotlin SDK on Android but we are still investigating the reasons.