Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced Features: Implement it #25

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jarstelfox
Copy link
Contributor

@jarstelfox jarstelfox commented Jul 15, 2024

This exists in the JS SDK, but not in the PHP sdk.

It's useful for cases like QA overrides during testing of features

Closes: #24

@jarstelfox jarstelfox force-pushed the forced-features-add-it branch from 8af0c68 to 4dffc2a Compare July 15, 2024 22:28
This exists in the JS SDK, but not in the PHP sdk.

It's useful for cases like QA overrides during testing of features
@jarstelfox jarstelfox force-pushed the forced-features-add-it branch from 4dffc2a to 584bce0 Compare July 15, 2024 22:29
Copy link
Contributor

@romain-growthbook romain-growthbook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for contributing!

@jarstelfox
Copy link
Contributor Author

Good morning! @romain-growthbook, I see the failing tests are unrelated to my changes and failing on the master branch

@romain-growthbook
Copy link
Contributor

Good morning! @romain-growthbook, I see the failing tests are unrelated to my changes and failing on the master branch

Yes.

@aburke07
Copy link

@romain-growthbook Are you able to merge this? We don't have write access to the repo.

@romain-growthbook romain-growthbook merged commit 9f3462d into growthbook:master Jul 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setForcedFeatures: It's missing
3 participants