Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh version requirements #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refresh version requirements #42

wants to merge 1 commit into from

Conversation

capripot
Copy link

@capripot capripot commented Feb 9, 2021 •
edited
Loading

  • Upped the Ruby version required to last supported branch: Ruby 2.5
  • Refreshed and relaxed gem versions requirements
  • Switched from HTTMultiParty (unsupported) to HTTParty since multipart upload is supported by HTTParty

@panozzaj
Copy link

This seems like a positive change, especially in light of the recent Mimemagic licensing issue: rails/rails#41757

panozzaj
panozzaj reviewed Mar 29, 2021
View reviewed changes
CHANGES.md
#### Added
- Upped the Ruby version required to last supported branch: Ruby 2.5
- Refreshed and relaxed gem versions requirements
- Switched from HTTMultiParty (unsupported) to HTTParty since multipart uplodad is supported by HTTParty
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: uplodad -> upload

@panozzaj
Copy link

This also seems like it would address #39 (if still an issue) based on httparty changelog and the httparty version pinned being after 0.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panozzaj panozzaj panozzaj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capripot @panozzaj