lsusb: improve usb2 device capability descriptor #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsundre
force-pushed
the
improve-usb2-extension-devcap
branch
from
3c50f1a to
95e9e60
Compare
Fix the following issues with the usb2 device capability descriptor
dump:
Currently, the BESL values claim to be in microseconds, but are actually
the raw, unshifted values from the descriptor. Use a lookup table for
the BESL values, based on Table X-X1 from "Errata for USB 2.0 ECN: Link
Power Management (LPM) - 7/2007" to display the actual microsecond
values.
Currently, the BESL values are displayed at the same indentation level
as bmAttributes, even though they are fields in bmAttributes. Adjust
indentation to align all fields of bmAttributes.
Change "BESL value" to "Baseline BESL value", to reflect the actual
names of the field.
Remove two unnecessary line breaks.
Before change:
USB 2.0 Extension Device Capability:
bLength 7
bDescriptorType 16
bDevCapabilityType 2
bmAttributes 0x0000f41e
BESL Link Power Management (LPM) Supported
BESL value 1024 us
Deep BESL value 61440 us
After change:
USB 2.0 Extension Device Capability:
bLength 7
bDescriptorType 16
bDevCapabilityType 2
bmAttributes 0x0000f41e
BESL Link Power Management (LPM) Supported
Baseline BESL value 400 us
Deep BESL value 10000 us
Signed-off-by: Torleiv Sundre <[email protected]>
tsundre
force-pushed
the
improve-usb2-extension-devcap
branch
from
95e9e60 to
5c02e04
Compare
|
Thanks, but this is failing the "Signed-off-by:" test, can you please fix that up? |
|
Looks great, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issues with the usb2 device capability descriptor dump:
Currently, the BESL values claim to be in microseconds, but are actually the raw, unshifted values from the descriptor. Use a lookup table for the BESL values, based on Table X-X1 from "Errata for USB 2.0 ECN: Link Power Management (LPM) - 7/2007" to display the actual microsecond values.
Currently, the BESL values are displayed at the same indentation level as bmAttributes, even though they are fields in bmAttributes. Adjust indentation to align all fields of bmAttributes.
Change "BESL value" to "Baseline BESL value", to reflect the actual names of the field.
Remove two unnecessary line breaks.
Before change:
After change: