-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change: boreas. Use sequence number 1. #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you don't mind my review. I'm not well versed in C so please take my review with the utmost of respect.
ba4c5f6
to
ee081c5
Compare
One note on the usage of "Fix:" for the conventional commit message: Shouldn't this be "Change:" instead? Asking because when using a "Fix" it will end up as a "Bug Fix" in the Changelog but this is far from being a Bug as the RFC is actually allowing to use a 0/zero:
and this is more about a compatibility with some specific systems not following the specs. |
a5c6689
to
566bae7
Compare
566bae7
to
d8d5d1e
Compare
What
Fix: boreas. Use sequence number 1
Close #812
Jira: SC-1064
Why
References
Checklist