feat: support prop list in all content usecases #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
NikitaCG
force-pushed
the
feat/support-prop-list-in-all-content-usecases
branch
from
338f02b to
cc0edff
Compare
gorgeousvlad
suggested changes
Mar 11, 2024
| @@ -32,6 +32,12 @@ const DefaultTemplate: StoryFn<ExtendedFeaturesBlockModel> = (args) => ( | |||
| const extendedFeaturesItems = (items: ExtendedFeaturesItem[]) => { | |||
| return items.map((item) => ({ | |||
| ...item, | |||
| list: | |||
| item.list && | |||
| @@ -21,31 +21,29 @@ export const TabsTextContent = ({ | |||
| centered, | |||
| contentSize = 's', | |||
| showMedia, | |||
| data, | |||
| data: {media, title, text, additionalInfo, link, links, buttons, list}, | |||
There was a problem hiding this comment.
but data could be undefined, no?
There was a problem hiding this comment.
data is required prop, inside data we have partial fields like media and we check his existence.
|
Playwright Test Component is ready. |
gorgeousvlad
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #818