feat: make other form optional (#49)

gravity-ui · May 4, 2024 · cec6a95 · cec6a95
1 parent a25cea2
commit cec6a95
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/plural/general.ts b/src/plural/general.ts
@@ -15,7 +15,14 @@ export function getPluralViaIntl(key: string, value: PluralValue, count: number,
     }
 
     const pluralRules = new Intl.PluralRules(lang);
-    return value[pluralRules.select(count)] || value.other;
+
+    const form = pluralRules.select(count);
+
+    if (form === 'other' && typeof value.other === 'undefined') {
+        return value.many || value.few;
+    }
+
+    return value[form] || value.other;
 }
 
 type FormatPluralArgs = {

diff --git a/src/types.ts b/src/types.ts
@@ -73,7 +73,7 @@ export type PluralValue = {
     two?: string;
     few?: string;
     many?: string;
-    other: string;
+    other?: string;
 }
 
 export function isPluralValue(value: KeyData): value is DeprecatedPluralValue | PluralValue {