Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto properties and misc code cleanup #398

Merged
merged 11 commits into from
Oct 20, 2024
Merged

Use auto properties and misc code cleanup #398

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2e384c6
Add .NET8 target
alexander-jesner-AP Oct 19, 2024
599e01f
Adress (performance related) warnings (which are treated as errors)
alexander-jesner-AP Oct 19, 2024
7e2ffb4
Adress (performance related) warnings (which are treated as errors)
alexander-jesner-AP Oct 19, 2024
92b2221
Chore: address minor warnings and clean up
alexander-jesner-AP Oct 19, 2024
ee6f1b1
Chore: use auto property syntax
alexander-jesner-AP Oct 19, 2024
a78a278
Cleanups
alexander-jesner-AP Oct 19, 2024
2078740
Revert "Add .NET8 target"
alexander-jesner-AP Oct 19, 2024
b579c8c
Chore: use auto property syntax
alexander-jesner-AP Oct 19, 2024
c003ee8
Chore: seal internal classes
alexander-jesner-AP Oct 19, 2024
c237632
Avoid async overhead in visitor methods
alexander-jesner-AP Oct 19, 2024
c2f7d2a
Address suggested code changes
alexander-jesner-AP Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLArgumentsDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,40 +23,17 @@ public GraphQLArgumentsDefinition(List<GraphQLInputValueDefinition> items)

internal sealed class GraphQLArgumentsDefinitionWithLocation : GraphQLArgumentsDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLArgumentsDefinitionWithComment : GraphQLArgumentsDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLArgumentsDefinitionFull : GraphQLArgumentsDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLDirectiveDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,40 +48,17 @@ public GraphQLDirectiveDefinition(GraphQLName name, GraphQLDirectiveLocations lo

internal sealed class GraphQLDirectiveDefinitionWithLocation : GraphQLDirectiveDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLDirectiveDefinitionWithComment : GraphQLDirectiveDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLDirectiveDefinitionFull : GraphQLDirectiveDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLEnumTypeDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,40 +34,17 @@ public GraphQLEnumTypeDefinition(GraphQLName name)

internal sealed class GraphQLEnumTypeDefinitionWithLocation : GraphQLEnumTypeDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLEnumTypeDefinitionWithComment : GraphQLEnumTypeDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLEnumTypeDefinitionFull : GraphQLEnumTypeDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLEnumValueDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,40 +41,17 @@ public GraphQLEnumValueDefinition(GraphQLName name, GraphQLEnumValue enumValue)

internal sealed class GraphQLEnumValueDefinitionWithLocation : GraphQLEnumValueDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLEnumValueDefinitionWithComment : GraphQLEnumValueDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLEnumValueDefinitionFull : GraphQLEnumValueDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLEnumValuesDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,40 +23,17 @@ public GraphQLEnumValuesDefinition(List<GraphQLEnumValueDefinition> items)

internal sealed class GraphQLEnumValuesDefinitionWithLocation : GraphQLEnumValuesDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLEnumValuesDefinitionWithComment : GraphQLEnumValuesDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLEnumValuesDefinitionFull : GraphQLEnumValuesDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLFieldDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,40 +44,17 @@ public GraphQLFieldDefinition(GraphQLName name, GraphQLType type)

internal sealed class GraphQLFieldDefinitionWithLocation : GraphQLFieldDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLFieldDefinitionWithComment : GraphQLFieldDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLFieldDefinitionFull : GraphQLFieldDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLFieldsDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,40 +23,17 @@ public GraphQLFieldsDefinition(List<GraphQLFieldDefinition> items)

internal sealed class GraphQLFieldsDefinitionWithLocation : GraphQLFieldsDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLFieldsDefinitionWithComment : GraphQLFieldsDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}

internal sealed class GraphQLFieldsDefinitionFull : GraphQLFieldsDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
31 changes: 4 additions & 27 deletions src/GraphQLParser/AST/Definitions/GraphQLFragmentDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,39 +40,16 @@ public GraphQLFragmentDefinition(GraphQLFragmentName name, GraphQLTypeCondition

internal sealed class GraphQLFragmentDefinitionWithLocation : GraphQLFragmentDefinition
{
private GraphQLLocation _location;

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}
public override GraphQLLocation Location { get; set; }
}

internal sealed class GraphQLFragmentDefinitionWithComment : GraphQLFragmentDefinition
{
private List<GraphQLComment>? _comments;

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
internal sealed class GraphQLFragmentDefinitionFull : GraphQLFragmentDefinition
{
private GraphQLLocation _location;
private List<GraphQLComment>? _comments;
public override GraphQLLocation Location { get; set; }

public override GraphQLLocation Location
{
get => _location;
set => _location = value;
}

public override List<GraphQLComment>? Comments
{
get => _comments;
set => _comments = value;
}
public override List<GraphQLComment>? Comments { get; set; }
}
Loading
Loading