feat: use new smart contract SubgraphAvailabilityManager for voting #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maikol
force-pushed
the
mde/interact-with-sam-contract
branch
from
9a1f0d2 to
9819d4b
Compare
tmigone
reviewed
Mar 6, 2024
| // 47642,1 | ||
| // | ||
| // 100 is considered as a good chunk size. | ||
| for chunk in denied_status.chunks(100) { |
There was a problem hiding this comment.
Not sure it matters today since we probably don't have chunks that big, but do you know if this gas profile was done on mainnet or arbitrum?
There was a problem hiding this comment.
yeah, good point, probably done on mainnet, we can update to use a different profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated oracle to support new
SubgraphAvailabilityManagercontract.Changes
SAO now accepts two configurations:
ORACLE_INDEXandSUBGRAPH_AVAILABILITY_MANAGER_CONTRACTREWARDS_MANAGER_CONTRACT