isOutputable protected, added tests to match required mutation score

graphpql · Apr 19, 2020 · 81d15f1 · 81d15f1
1 parent b51b204
commit 81d15f1
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/src/Exception/GraphpinatorBase.php b/src/Exception/GraphpinatorBase.php
@@ -21,11 +21,6 @@ public function __construct(?\Graphpinator\Source\Location $location = null, ?Pa
         $this->extensions = $extensions;
     }
 
-    public function isOutputable() : bool
-    {
-        return false;
-    }
-
     final public function jsonSerialize() : array
     {
         if (!$this->isOutputable()) {
@@ -57,4 +52,9 @@ public static function notOutputableResponse() : array
             'message' => 'Server responded with unknown error.'
         ];
     }
+
+    protected function isOutputable() : bool
+    {
+        return false;
+    }
 }
diff --git a/src/Exception/Parser/ParserError.php b/src/Exception/Parser/ParserError.php
@@ -6,7 +6,7 @@
 
 abstract class ParserError extends \Graphpinator\Exception\GraphpinatorBase
 {
-    public function isOutputable() : bool
+    protected function isOutputable() : bool
     {
         return true;
     }

diff --git a/src/Exception/Tokenizer/TokenizerError.php b/src/Exception/Tokenizer/TokenizerError.php
@@ -6,7 +6,7 @@
 
 abstract class TokenizerError extends \Graphpinator\Exception\GraphpinatorBase
 {
-    public function isOutputable() : bool
+    protected function isOutputable() : bool
     {
         return true;
     }

diff --git a/tests/Spec/ErrorsTest.php b/tests/Spec/ErrorsTest.php
@@ -24,6 +24,10 @@ public function simpleDataProvider() : array
                 'query queryName { field0 @invalidDirective() { field1 { name } } }',
                 \Infinityloop\Utils\Json::fromArray(['errors' => [['message' => 'Server responded with unknown error.']]]),
             ],
+            [
+                'query queryName { fieldThrow { field1 { name } } }',
+                \Infinityloop\Utils\Json::fromArray(['errors' => [['message' => 'Server responded with unknown error.']]]),
+            ],
         ];
     }
 

diff --git a/tests/Spec/TestSchema.php b/tests/Spec/TestSchema.php
@@ -79,6 +79,9 @@ protected function getFieldDefinition() : \Graphpinator\Field\ResolvableFieldSet
                     }),
                     new \Graphpinator\Field\ResolvableField('fieldAbstract', TestSchema::getUnion(), static function () {
                         return 1;
+                    }),
+                    new \Graphpinator\Field\ResolvableField('fieldThrow', TestSchema::getUnion(), static function () {
+                        throw new \Exception('Random exception');
                     })
                 ]);
             }