Skip to content

Commit

Permalink
[tempo-distributed] switch to new overrides format
Browse files Browse the repository at this point in the history
Signed-off-by: Jan Jansen <[email protected]>
  • Loading branch information
farodin91 committed Feb 29, 2024
1 parent df7ae36 commit 6162f55
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 17 deletions.
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.8.4
version: 1.8.5
appVersion: 2.3.1
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
15 changes: 10 additions & 5 deletions charts/tempo-distributed/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tempo-distributed

![Version: 1.8.4](https://img.shields.io/badge/Version-1.8.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.3.1](https://img.shields.io/badge/AppVersion-2.3.1-informational?style=flat-square)
![Version: 1.8.5](https://img.shields.io/badge/Version-1.8.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.3.1](https://img.shields.io/badge/AppVersion-2.3.1-informational?style=flat-square)

Grafana Tempo in MicroService mode

Expand Down Expand Up @@ -45,6 +45,10 @@ The command removes all the Kubernetes components associated with the chart and

A major chart version change indicates that there is an incompatible breaking change needing manual actions.

### From Chart versions < 1.8.0

Switch to new overrides format, see https://grafana.com/docs/tempo/latest/configuration/#overrides.

### From Chart versions < 1.6.0

The metrics generator component in the chart has been disabled by default, but the configuration for the processors was not empty, resulting error sin the distributor log. Here we align the default metrics generator config settings to both disable the generator and remove processors. Users who wish to keep the their processors enabled, will need to update their values.
Expand Down Expand Up @@ -452,7 +456,6 @@ The memcached default args are removed and should be provided manually. The sett
| global.image.pullSecrets | list | `[]` | Optional list of imagePullSecrets for all images, excluding enterprise. Names of existing secrets with private container registry credentials. Ref: https://kubernetes.io/docs/concepts/containers/images/#specifying-imagepullsecrets-on-a-pod Example: pullSecrets: [ my-dockerconfigjson-secret ] |
| global.image.registry | string | `"docker.io"` | Overrides the Docker registry globally for all images, excluding enterprise. |
| global.priorityClassName | string | `nil` | Overrides the priorityClassName for all pods |
| global_overrides.metrics_generator_processors | list | `[]` | List of enabled metrics generator processors ([service-graphs, span-metrics]) |
| global_overrides.per_tenant_override_config | string | `"/runtime-config/overrides.yaml"` | |
| ingester.affinity | string | Soft node and soft zone anti-affinity | Affinity for ingester pods. Passed through `tpl` and, thus, to be configured as string |
| ingester.annotations | object | `{}` | Annotations for the ingester StatefulSet |
Expand Down Expand Up @@ -840,9 +843,11 @@ metricsGenerator:
# x-scope-orgid: operations
# Global overrides
global_overrides:
metrics_generator_processors:
- service-graphs
- span-metrics
defaults:
metrics_generator:
processors:
- service-graphs
- span-metrics
```

----
Expand Down
12 changes: 9 additions & 3 deletions charts/tempo-distributed/README.md.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ The command removes all the Kubernetes components associated with the chart and

A major chart version change indicates that there is an incompatible breaking change needing manual actions.

### From Chart versions < 1.8.0

Switch to new overrides format, see https://grafana.com/docs/tempo/latest/configuration/#overrides.

### From Chart versions < 1.6.0

The metrics generator component in the chart has been disabled by default, but the configuration for the processors was not empty, resulting error sin the distributor log. Here we align the default metrics generator config settings to both disable the generator and remove processors. Users who wish to keep the their processors enabled, will need to update their values.
Expand Down Expand Up @@ -261,9 +265,11 @@ metricsGenerator:
# x-scope-orgid: operations
# Global overrides
global_overrides:
metrics_generator_processors:
- service-graphs
- span-metrics
defaults:
metrics_generator:
processors:
- service-graphs
- span-metrics
```

----
Expand Down
8 changes: 0 additions & 8 deletions charts/tempo-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1255,12 +1255,6 @@ config: |
- dns+{{ include "tempo.fullname" . }}-gossip-ring:{{ .Values.memberlist.bind_port }}
overrides:
{{- toYaml .Values.global_overrides | nindent 2 }}
{{- if .Values.metricsGenerator.enabled }}
metrics_generator_processors:
{{- range .Values.global_overrides.metrics_generator_processors }}
- {{ . }}
{{- end }}
{{- end }}
server:
http_listen_port: {{ .Values.server.httpListenPort }}
log_level: {{ .Values.server.logLevel }}
Expand Down Expand Up @@ -1359,8 +1353,6 @@ storage:
# Global overrides
global_overrides:
per_tenant_override_config: /runtime-config/overrides.yaml
# -- List of enabled metrics generator processors ([service-graphs, span-metrics])
metrics_generator_processors: []

# Per tenants overrides
overrides: |
Expand Down

0 comments on commit 6162f55

Please sign in to comment.