Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Prometheus v0.53.2 #7036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to Prometheus v0.53.2 #7036

wants to merge 1 commit into from

Conversation

ptodev
Copy link
Contributor

@ptodev ptodev commented Sep 24, 2024 •
edited
Loading

PR Description

Updating to Prometheus v0.53.2.

I was not able to upgrade to Prometheus v2.54.1, because firstly Loki will have to be upgraded to Prometheus v2.55.0 and that version of Prometheus hasn't been released yet.

After this PR is merged, I we should probably also port this bugfix to the Agent.

This I need to do before taking the PR out of draft:

  • Local testing to make sure static mode metrics work properly during config reloads.
  • Update changelog
  • Make sure static mode, Flow, and converters support all the new config arguments added to Prometheus
  • Port any new config arguments to Alloy

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@ptodev ptodev force-pushed the ptodev/update-prometheus branch 3 times, most recently from 3e660c1 to 84017f5 Compare September 24, 2024 17:43
@ptodev ptodev mentioned this pull request Oct 10, 2024
Closed
@ptodev ptodev force-pushed the ptodev/update-prometheus branch 3 times, most recently from 87571d8 to abefc9d Compare November 21, 2024 17:31
@ptodev ptodev marked this pull request as ready for review November 21, 2024 17:31
@ptodev ptodev force-pushed the ptodev/update-prometheus branch from abefc9d to 260dd28 Compare November 21, 2024 18:08
@ptodev
Copy link
Contributor Author

ptodev commented Nov 22, 2024

Unfortunately, I found out I need to change a few more things for this PR... Most notably I'll need to patch the Loki branch.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 25, 2024
@clayton-cornell clayton-cornell requested a review from a team November 25, 2024 15:40
@ptodev ptodev force-pushed the ptodev/update-prometheus branch from 260dd28 to 95ed222 Compare December 3, 2024 18:06
@clayton-cornell
Copy link
Contributor

Docs are fin as-is.

@github-actions GitHub Actions
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayton-cornell clayton-cornell Awaiting requested review from clayton-cornell clayton-cornell is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-attention An issue or PR has been sitting around and needs attention. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptodev @clayton-cornell