Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump build image usage to 0.30.3 #5483

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

tpaschalis
Copy link
Member

This bumps the build-image to the newly pushed v0.30.3 tag which makes use of Go 1.21.3

@tpaschalis tpaschalis requested review from a team as code owners October 16, 2023 11:04
@@ -44,6 +44,9 @@ Main (unreleased)

- Allow converting labels to structured metadata with Loki's structured_metadata stage. (@gonzalesraul)

### Other changes

- Use Go 1.21.3 for builds. (@tpaschalis)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess agent-build-image:0.30.3 contains a new Go version? But how was agent-build-image updated? I'd expect it to be via this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ptodev

The process is
a) Update the build-image directory with a PR like this
b) Push a build-image/v0.X.Y tag
c) Wait for the automation to create and push the new build-image, make another PR to use it (like here).

Do you think it makes sense to document the process under docs/developer so people have some reference PRs to look at?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you - it'd be great to have something in docs/developer about it.

@tpaschalis tpaschalis merged commit a202b0a into grafana:main Oct 16, 2023
@tpaschalis tpaschalis deleted the bump-build-image-v0.30.3 branch October 16, 2023 11:43
tpaschalis added a commit to tpaschalis/agent that referenced this pull request Oct 16, 2023
Signed-off-by: Paschalis Tsilias <[email protected]>
(cherry picked from commit a202b0a)
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants