Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes response.Body leak #928

Closed
wants to merge 1 commit into from
Closed

fixes response.Body leak #928

wants to merge 1 commit into from

Conversation

przmv
Copy link

@przmv przmv commented Jun 13, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: there's no need to
  • I need help with writing tests

Run verifications and test

  • make verify is passing (ain't passing on master neither)
  • make test is passing

@ghost
Copy link

ghost commented Jun 14, 2024

See https://github.com/tebuka/websocket/commit/e5fb68fedb4f7fc8af97036bd717590e4b60459f.

Cherry-pick the Tebuka commit instead of merging this PR.

@jaitaiwan jaitaiwan mentioned this pull request Jun 19, 2024
Merged
6 tasks
@jaitaiwan
Copy link
Member

Closed in favour of #937

@jaitaiwan jaitaiwan closed this Jun 19, 2024
@przmv przmv deleted the fix-proxy-leak-body branch June 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Potential Handle Leak?
2 participants
@przmv @jaitaiwan