Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Rails 7.2.0 #328

Merged
merged 4 commits into from
Dec 11, 2024
Merged

feat: support Rails 7.2.0 #328

merged 4 commits into from
Dec 11, 2024

Conversation

ruzia
Copy link
Contributor

@ruzia ruzia commented Dec 8, 2024

@ruzia ruzia requested review from olavloite and a team as code owners December 8, 2024 15:08
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Dec 8, 2024
@ruzia ruzia force-pushed the support_rails_7_2 branch 4 times, most recently from 3ba2079 to 7211b04 Compare December 9, 2024 13:35
@ruzia ruzia force-pushed the support_rails_7_2 branch from 7211b04 to 04320cb Compare December 10, 2024 01:50
@olavloite olavloite mentioned this pull request Dec 10, 2024
Closed
@olavloite
Copy link
Collaborator

@ruzia Thank you so much for working on this!

I've added a few minor cleanups in #330, as I don't have push permission on your branch. Would you mind incorporating those changes into your PR. Then we can merge this.

@olavloite olavloite changed the title fix: Support for changes in Rails 7.2.0. feat: support Rails 7.2.0 Dec 10, 2024
@ruzia
Copy link
Contributor Author

ruzia commented Dec 11, 2024

@olavloite Thanks for reply!
I have merged the commits and added write permissions.
Could you please check?

@olavloite olavloite merged commit 8d9d2fa into googleapis:main Dec 11, 2024
36 checks passed
@release-please release-please bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruzia @olavloite