Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix combination of composite primary keys and Rails 7.0 #294

Closed
wants to merge 1 commit into from

Conversation

Connorhd
Copy link
Contributor

This method changed to have 2 arguments in Rails 7.1, and changes in #278 to support that cause this to error on Rails 7.0. Call super with the appropriate arguments on older versions of Rails.

This method changed to have 2 arguments in Rails 7.1, and changes in googleapis#278 to support that cause this to error on Rails 7.0. Call super with the appropriate arguments on older versions of Rails.
@Connorhd Connorhd requested review from olavloite and a team as code owners January 12, 2024 03:24
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/ruby-spanner-activerecord API. label Jan 12, 2024
@olavloite
Copy link
Collaborator

@Connorhd Version 1.6.1 contains the fix that was added in #298. That fix should also fix this problem. Would you mind trying that out? Please let me know if it does not fix this problem.

@Connorhd
Copy link
Contributor Author

Yep that works, thanks!

@Connorhd Connorhd closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/ruby-spanner-activerecord API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants