feat: support bit-reversed sequences #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
olavloite
added a commit
that referenced
this pull request
Dec 20, 2023
* feat: support Rails 7.1 * chore: make stuff compatible with 7.1 * test: add 7.1 to test matrix * fix: replace constant with literal * chore: fix rubocop issues * chore: cleanup * chore: assign shorter class names * feat: interleaved tables with built-in composite pk Adds support for interleaved tables using the built-in support for composite primary keys in Rails 7.1. The original support for interleaved tables using the third-party composite-primary-key gem still works for Rails vresions < 7.1. Anyone updgrading from Rails 7.0 to 7.1 and using interleaved tables must update their code to use the new built-in feature for composite primary keys, and must remove the third-party composite primary keys gem. The latter will automatically show up as a problem, as there is no version of that gem that supports Rails 7.1. Fixes #281 * docs: add sample for interleaved tables * docs: make interleaved tables before/after 7.1 work * chore: fix rubocop issues * feat: support bit-reversed sequences (#276) * feat: support bit-reversed sequences * chore: cleanup * fix: add pk to returning statement for Rails 7.1 and higher * chore: fix rubocop issues * test: add mock server + acceptance tests * test: fix expected sql for prod * fix: only check positive ID for prod * docs: add example for using bit-reversed sequence * chore: address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support bit-reversed sequences and
THEN RETURNclauses to generate primary key values.The current example uses
FARM_FINGERPRINT(GENERATE_UUID())instead ofGET_NEXT_SEQUENCE_VALUE(SEQUENCE singer_sequence)for the time being, as bit-reversed sequences are not yet supported on the emulator. All other parts of this feature will remain unchanged once this is supported.