review comments

googleapis · Dec 26, 2024 · db2938b · db2938b
1 parent 699656d
commit db2938b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/database.ts b/src/database.ts
@@ -2095,7 +2095,7 @@ class Database extends common.GrpcServiceObject {
         ? (optionsOrCallback as TimestampBounds)
         : {};
 
-    if ('maxStaleness' in options || 'minReadTimestamp' in options) {
+    if (options !=null && (options['maxStaleness'] != null || options['minReadTimestamp'] != null)) {
       const error = Object.assign(
         new Error(
           'maxStaleness / minReadTimestamp is not supported for multi-use read-only transactions.'

diff --git a/test/database.ts b/test/database.ts
@@ -2331,6 +2331,15 @@ describe('Database', () => {
       });
     });
 
+    it('should pass when maxStaleness is undefined', () => {
+      const fakeTimestampBounds = {minReadTimestamp: undefined};
+
+      database.getSnapshot(fakeTimestampBounds, assert.ifError);
+
+      const bounds = snapshotStub.lastCall.args[0];
+      assert.strictEqual(bounds, fakeTimestampBounds);
+    });
+
     it('should begin a snapshot', () => {
       beginSnapshotStub.callsFake(() => {});