Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add authorized view bindings to Cloud Bigtable data APIs and messages #2144

Merged
merged 7 commits into from
Mar 5, 2024
Merged

feat: Add authorized view bindings to Cloud Bigtable data APIs and messages #2144

merged 7 commits into from
Mar 5, 2024

Conversation

trollyxia
Copy link
Member

This is essentially the same as #2141, with an additional commit which fixes the unit test.

original PR description:

docs: The field table_name in message .google.bigtable.v2.ReadRowsRequest is changed from required to optional

docs: The field table_name in message .google.bigtable.v2.SampleRowKeysRequest is changed from required to optional

docs: The field table_name in message .google.bigtable.v2.MutateRowRequest is changed from required to optional

docs: The field table_name in message .google.bigtable.v2.MutateRowsRequest is changed from required to optional

docs: The field table_name in message .google.bigtable.v2.CheckAndMutateRowRequest is changed from required to optional

docs: The field table_name in message .google.bigtable.v2.ReadModifyWriteRowRequest is changed from required to optional
PiperOrigin-RevId: 612537984

Source-Link: https://github.com/googleapis/googleapis/commit/6465963c92930626473457717ff697aeb1bf4a12

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f4a996071801f559bb6f4d0c99bb9a3c0ecf4844
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhOTk2MDcxODAxZjU1OWJiNmY0ZDBjOTliYjlhM2MwZWNmNDg0NCJ9

BEGIN_NESTED_COMMIT
feat: Cloud Bigtable Authorized Views admin APIs protos
PiperOrigin-RevId: 612537460

Source-Link: https://github.com/googleapis/googleapis/commit/b98fe7ff808454e9d11a83946f40259ea9c6a63b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/03d9b5c5517cf9123f120461180ebdd387a47bcc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDNkOWI1YzU1MTdjZjkxMjNmMTIwNDYxMTgwZWJkZDM4N2E0N2JjYyJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0
PiperOrigin-RevId: 611816371

Source-Link: https://github.com/googleapis/googleapis/commit/2a40f63ea714c7f4c6856a5db4d1f3cc7d4c4b18

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9
END_NESTED_COMMIT

gcf-owl-bot bot added 6 commits March 1, 2024 19:55
@gcf-owl-bot
fix(deps): Update the Java code generator (gapic-generator-java) to 2…
770bdb2 
….37.0

PiperOrigin-RevId: 611816371

Source-Link: googleapis/googleapis@2a40f63

Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
df52a73 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: Cloud Bigtable Authorized Views admin APIs protos
38d1d9e 
PiperOrigin-RevId: 612537460

Source-Link: googleapis/googleapis@b98fe7f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/03d9b5c5517cf9123f120461180ebdd387a47bcc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDNkOWI1YzU1MTdjZjkxMjNmMTIwNDYxMTgwZWJkZDM4N2E0N2JjYyJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
d8c8f31 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot
feat: Add authorized view bindings to Cloud Bigtable data APIs and me…
c94cf0f 
…ssages

docs: The field `table_name` in message `.google.bigtable.v2.ReadRowsRequest` is changed from required to optional

docs: The field `table_name` in message `.google.bigtable.v2.SampleRowKeysRequest` is changed from required to optional

docs: The field `table_name` in message `.google.bigtable.v2.MutateRowRequest` is changed from required to optional

docs: The field `table_name` in message `.google.bigtable.v2.MutateRowsRequest` is changed from required to optional

docs: The field `table_name` in message `.google.bigtable.v2.CheckAndMutateRowRequest` is changed from required to optional

docs: The field `table_name` in message `.google.bigtable.v2.ReadModifyWriteRowRequest` is changed from required to optional
PiperOrigin-RevId: 612537984

Source-Link: googleapis/googleapis@6465963

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f4a996071801f559bb6f4d0c99bb9a3c0ecf4844
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjRhOTk2MDcxODAxZjU1OWJiNmY0ZDBjOTliYjlhM2MwZWNmNDg0NCJ9
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
acc4f02 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@trollyxia trollyxia requested review from a team as code owners March 4, 2024 23:01
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Mar 4, 2024
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/gapic_metadata.json
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStubSettings.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStubSettings.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java
  • google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/GrpcBigtableStub.java
  • google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClientTest.java
  • google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/MockBigtableTableAdminImpl.java
  • grpc-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BigtableTableAdminGrpc.java
  • proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/BigtableTableAdminProto.java
  • proto-google-cloud-bigtable-admin-v2/src/main/java/com/google/bigtable/admin/v2/TableProto.java
  • proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto
  • proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/table.proto
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/BigtableProto.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/CheckAndMutateRowRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/CheckAndMutateRowRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/MutateRowRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/MutateRowRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/MutateRowsRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/MutateRowsRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadModifyWriteRowRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadModifyWriteRowRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadRowsRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/ReadRowsRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/SampleRowKeysRequest.java
  • proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/SampleRowKeysRequestOrBuilder.java
  • proto-google-cloud-bigtable-v2/src/main/proto/google/bigtable/v2/bigtable.proto

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Mar 4, 2024
Fix unit test broken by the new authorized views apis
dd80086 
Change-Id: I075e896a696d83c70f72337f2921d3285e408e1e
@trollyxia trollyxia force-pushed the authorized_view_proto branch from 4b7ebf0 to dd80086 Compare March 5, 2024 15:13
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@mutianf mutianf merged commit ae89709 into googleapis:main Mar 5, 2024
21 checks passed
@release-please release-please bot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trollyxia @mutianf