Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): manually updating the Libraries BOM #1977

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Oct 26, 2023

Somehow the RenovateBot stopped working for libraries-bom
in this repository. Troubleshooting:
googleapis/synthtool#1844

Followed https://github.com/googleapis/java-bigtable/pull/1868/files to locate the files.

Somehow the RenovateBot stopped working for libraries-bom
in this repository. Troubleshooting:
googleapis/synthtool#1844

Followed https://github.com/googleapis/java-bigtable/pull/1868/files
@suztomo suztomo requested review from a team as code owners October 26, 2023 14:59
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 26, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Oct 26, 2023
@suztomo
Copy link
Member Author

suztomo commented Oct 26, 2023

samples/snippets/pom.xml is templated, really?

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2023
@suztomo
Copy link
Member Author

suztomo commented Oct 26, 2023

No, samples/snippets/pom.xml is not templated.

Copy link
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a question: do we need to manually update the version in each release cycle?

@suztomo suztomo merged commit bff9ba5 into googleapis:main Oct 26, 2023
15 checks passed
@suztomo
Copy link
Member Author

suztomo commented Oct 26, 2023

No, that's not in the todo items.

I'm experimenting how RenovateBot reacts after I manually update these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants