Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storage): indicate that gRPC is incompatible with universe domains #9386

Merged
merged 3 commits into from
Feb 8, 2024
Merged

docs(storage): indicate that gRPC is incompatible with universe domains #9386

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ff8b44
docs(storage): indicate that gRPC is incompatible with universe domains
BrennaEpp Feb 8, 2024
0a8b032
suggestion
BrennaEpp Feb 8, 2024
b641429
Merge branch 'main' into docs-tpc
BrennaEpp Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ func NewClient(ctx context.Context, opts ...option.ClientOption) (*Client, error
// NewGRPCClient creates a new Storage client using the gRPC transport and API.
// Client methods which have not been implemented in gRPC will return an error.
// In particular, methods for Cloud Pub/Sub notifications are not supported.
// Using a non-default universe domain is also not supported in gRPC.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just a tiny bit worried about this sentence being taken out of context. Can you change it to:

"Using a non-default universe domain is also not supported in the Storage gRPC client."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. Updated!

//
// The storage gRPC API is still in preview and not yet publicly available.
// If you would like to use the API, please first contact your GCP account rep to
Expand Down
Loading