feat(bigtable/bttest): Implement change streams #9203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an important semantic property of BigTable: "All mutations in a single write request have the same timestamp unless you override them." https://cloud.google.com/bigtable/docs/writes#write-types
Implement the GenerateInitialChangeStreamPartitions and ReadChangeStream BigtableServer methods, and record and serve change streams for tables that are created with a ChangeStreamConfig specified. Note: this change does not implement sending Heartbeat records from ReadChangeStream, and the retention period specified by the client is not honored. These are left as TODOs.
|
I'm not sure why those conformance tests are failing. Any pointers? |
codyoss
changed the title
product-auto-label
bot
added
the
api: bigtable
|
The conformance tests were added in failed state. Their failures can be ignored |
|
What is the bug related to commit times? |
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
|
@bhshkh to quote the commit message:
|
|
Our use-case for this is that we have a service that uses change streams and we want to be able to test it locally. |
bhshkh
approved these changes
Jul 18, 2024
|
@adg , can you please sign the CLA to merge the PR. please visit https://cla.developers.google.com/ |
|
@adg can you please sign the CLA if you would still like these changes, or else we can close this PR if you are no longer interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add an implementation of the GenerateInitialChangeStreamPartitions and ReadChangeStream BigtableServer methods to the bttest package, and also fix a bug related to commit times.