-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add new open census metrics for long-running sessions removal #8975
Open
harshachinta
wants to merge
8
commits into
googleapis:main
Choose a base branch
from
harshachinta:session-leak-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: spanner
Issues related to the Spanner API.
labels
Nov 4, 2023
rahul2393
approved these changes
Nov 6, 2023
harshachinta
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 7, 2023
product-auto-label
bot
added
the
stale: old
Pull request is old and needs attention.
label
Dec 4, 2023
product-auto-label
bot
added
stale: extraold
Pull request is critically old and needs prioritization.
and removed
stale: old
Pull request is old and needs attention.
labels
Jan 3, 2024
@harshachinta can we close or merge this? |
@harshachinta see my comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the Spanner API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
size: m
Pull request size is medium.
stale: extraold
Pull request is critically old and needs prioritization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO NOT MERGE]
This PR adds a new session pool metrics using open census.
cloud.google.com/go/spanner/num_long_running_sessions_removed
- The number of long-running sessions removed from the session pool.This
num_long_running_sessions_removed
metric will be emitted only whenActionOnInactiveTransaction
is eitherWarnAndClose
orClose
. This is because in rest of the cases there will be no change to this value and will always be0
.Wrote unit test for testing the new metric emitted.
Real time testing
Metric dashboard - (https://screenshot.googleplex.com/9YqA4bmHoDGwsbo)
Used the below sample code to test the metric