feat(spanner): support of uint datatype for gorm.Model #8935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul2393
added
the
kokoro:force-run
| @@ -3471,6 +3471,30 @@ func encodeValue(v interface{}) (*proto3.Value, *sppb.Type, error) { | |||
| } | |||
| } | |||
| pt = listType(intType()) | |||
| case uint: | |||
There was a problem hiding this comment.
nit: shouldn't we add support for uint type in decodeValue method also?
There was a problem hiding this comment.
gorm.Model tests were able decode to uint without making any changes in decodeValue function, seems like default case is sufficient, let me add tests validating it
harshachinta
approved these changes
Oct 30, 2023
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
|
@rahul2393 do we still want this change? |
|
@rahul2393 see my comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang ORM (GORM) customers use gorm.Model for declaring the models in application code, this PR will add support of
uinttype in Cloud Spanner client library since Cloud Spanner does not support uint datatype natively