feat(spanner/spansql): Add tests and parser support for THEN RETURN #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Integration tests are not expected to pass until |
rajatbhatta
reviewed
Aug 22, 2022
codyoss
changed the title
rahul2393
reviewed
Aug 23, 2022
| @@ -24,6 +24,7 @@ by ascending esotericism: | |||
| - SELECT HAVING | |||
| - more literal types | |||
| - DEFAULT | |||
| - THEN RETURN | |||
There was a problem hiding this comment.
We are supporting it through this PR, right? I guess we want to say PG.Returning is not supported.
There was a problem hiding this comment.
No, I did not intend to add this support myself. We will be adding support to the standard Spanner Emulator however.
rajatbhatta
reviewed
Aug 24, 2022
c2nes
force-pushed
the
dml-then-return
branch
2 times, most recently
from
c4e306b to
71a8c62
Compare
This change adds THEN RETURN support for DML statements. The existing "Query" methods already support executing such statements, so this change is limited to updating documentation, adding integration tests, and updating the spansql package. Support has not been added to the spannertest in-memory implementation of Spanner, but the feature absence has been noted in the corresponding README.
rahul2393
approved these changes
Sep 2, 2022
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rajatbhatta
added
the
do not merge
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
rahul2393
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@rahul2393 are there still plans to accecpt this PR? |
|
@rahul2393 see comment above ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds THEN RETURN support for DML statements. The existing "Query" methods already support executing such statements, so this change is limited to updating documentation, adding integration tests, and updating the spansql package. Support has not been added to the spannertest in-memory implementation of Spanner, but the feature absence has been noted in the corresponding README.