chore(spanner): handle commit retry protocol extension for mux rw #11472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul2393
force-pushed
the
mux-commit-retry
branch
from
2a058fe to
3dba7b6
Compare
rahul2393
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
rahul2393
added
the
kokoro:force-run
harshachinta
approved these changes
Jan 21, 2025
| return resp, t.txReadOnly.updateTxState(toSpannerErrorWithCommitInfo(err, true)) | ||
| } | ||
| // Retry if MultiplexedSessionRetry is present, without mutations | ||
| if res.GetMultiplexedSessionRetry() != nil { |
There was a problem hiding this comment.
nit: Here can we get the precommit token, pass it to setPrecommitToken method and then below use t.precommittoken?
I understand that the precommittoken reveived in res should be latest but here we will need to rely on sequence number to determine that the precommit token is indeed latest. This will save us in future in cases where the precommit token received in res could be outdated.
Comment on lines
+559
to
+560
| if _, err := tx.Update(ctx, Statement{SQL: UpdateBarSetFoo}); err != nil { | ||
| return err |
There was a problem hiding this comment.
Commit retry only happens in cases of DQL+Mutation. Lets remove DML to avoid confusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a read-write transaction using a multiplexed session with (read/query + mutation) operations, the CommitResponse from the backend during the commit RPC may include a MultiplexedSessionRetry field (indicated by a precommit token). This field signals that the commit RPC should be retried once using the new precommit token. During this retry, mutations should not be resent, as they were already buffered in spanFE during the initial commit RPC call.