fix(bigtable): Allow nil condition in conditional mutation #11457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the test proxy receives a conditional mutation request with nil condition, it uses the PassAllFilter to call Apply method of Go library. Thus, the request sent by Go library to Cloud Bigtable service contains the field pass all filter.
TestCheckAndMutateRow_NoRetry_TrueMutations conformance test fails with error
The Go library assumes that the field
cond
inMutation
being non-nil denotes conditional mutation but as per the above test we want to allow conditional mutation with no condition. So, a new variableisConditional
is being added toMutation
to distinguish between conditional and non-conditional mutations.After fix: