feat(datastore): Add read time from client while running queries #11447
+178
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11012
User can create a client with read time option. This option wasn't getting passed in RunQueryRequest and RunAggregationQueryRequest. This PR adds this option.
google-cloud-go/datastore/apiv1/datastorepb/datastore.pb.go
Lines 464 to 465 in 93e313d
google-cloud-go/datastore/apiv1/datastorepb/datastore.pb.go
Lines 701 to 702 in 93e313d
google-cloud-go/datastore/apiv1/datastorepb/datastore.pb.go
Lines 2184 to 2205 in 93e313d
As can be seen in above proto, the consistency type field in ReadOptions can be one of ReadOptions_ReadConsistency_, ReadOptions_Transaction, ReadOptions_NewTransaction or ReadOptions_ReadTime. Same validation has been added on client