fix(bigtable): Do not retry conditional mutate #11437
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/387315971
Fixes TestCheckAndMutateRow_NoRetry_TransientError
Before fix:
After fix:
We don't know if the conditional mutation has been applied so we can't retry them.
Updated the retry to match Java's retry settings:
https://github.com/googleapis/java-bigtable/blob/7df848e39ca045a0579c9e359457aa20741d8983/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java#L810-L811
https://github.com/googleapis/java-bigtable/blob/7df848e39ca045a0579c9e359457aa20741d8983/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java#L458-L461
https://github.com/googleapis/java-bigtable/blob/7df848e39ca045a0579c9e359457aa20741d8983/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java#L296-L297