feat(storage): fix mutex use and CloseSend before close #11432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
BrennaEpp
reviewed
Jan 11, 2025
Comment on lines
-1376
to
1378
| r.mu.Lock() | ||
| defer r.mu.Unlock() | ||
| var activeRange []rangeSpec |
There was a problem hiding this comment.
What's the guarantee here? That if getActiveRange is running, no other goroutine will be running as well that may access the map? I don't think we can guarantee that since Wait() might be running, right?
There was a problem hiding this comment.
You can trigger this situation running go test -v -short -run="TestRetryConformance/grpc-8-\[return-broken-stream\]-storage.objects.download-3" -race
BrennaEpp
reviewed
Jan 11, 2025
Comment on lines
+1472
to
+1474
| if err := mr.stream.CloseSend(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Should we also drain the stream after the CloseSend (as we do in drainInboundStream(), receiving from stream until we get a non-nil error) to make sure its resources are released? See grpc/grpc-go@365770f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed mutex call around getActiveRange as that will be called from one go routine at a single time.
Added mutex call around streamReceiver ctx.Done() case similar to streamManager.