feat(spanner): add mTLS support external spanner hosts #11381
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul2393
reviewed
Jan 15, 2025
| } | ||
| capool := x509.NewCertPool() | ||
| if !capool.AppendCertsFromPEM(ca) { | ||
| return nil, fmt.Errorf("failed to append the CA certificate to CA pool") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("failed to append the CA certificate to CA pool") | |
| return nil, errors.New("failed to append the CA certificate to CA pool") |
| // - The returned gRPC connection can be passed to `option.WithGRPCConn(grpcConn)` to create a client using mTLS. | ||
| func NewMtlsConn(endpoint, caCertificate, clientCertificate, clientCertificateKey string) (*grpc.ClientConn, error) { | ||
| if clientCertificate == "" || clientCertificateKey == "" { | ||
| return nil, fmt.Errorf("client certificate and key are mandatory for mTLS connection") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("client certificate and key are mandatory for mTLS connection") | |
| return nil, errors.New("client certificate and key are mandatory for mTLS connection") |
| clientCerts := []tls.Certificate{cert} | ||
|
|
||
| if caCertificate == "" { | ||
| return nil, fmt.Errorf("ca certificate is required for mTLS connection") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("ca certificate is required for mTLS connection") | |
| return nil, errors.New("ca certificate is required for mTLS connection") |
| @@ -1399,6 +1402,67 @@ func (c *Client) BatchWriteWithOptions(ctx context.Context, mgs []*MutationGroup | |||
| } | |||
| } | |||
|
|
|||
| // CertPool creates a x509.CertPool from the given CA certificate file. | |||
| func CertPool(caCertFile string) (*x509.CertPool, error) { | |||
There was a problem hiding this comment.
Do we want it to be public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for creating gRPC client connection using mutual TLS (mTLS) for external spanner hosts