chore(spanner): Add changes in Spanner executor for testing end to end tracing #10450
Conversation
…into systest-otel-context
…into systest-changes
…into e2e-trace-optin
…into systest-changes
…into systest-changes
spanner/test/cloudexecutor/executor/internal/inputstream/handler.go
Outdated
Show resolved
Hide resolved
spanner/test/cloudexecutor/executor/internal/inputstream/handler.go
Outdated
Show resolved
Hide resolved
spanner/test/cloudexecutor/executor/executor_proxy_server_impl.go
Outdated
Show resolved
Hide resolved
spanner/test/cloudexecutor/executor/internal/inputstream/handler.go
Outdated
Show resolved
Hide resolved
…into systest-changes
…into systest-changes
spanner/test/cloudexecutor/executor/executor_proxy_server_impl.go
Outdated
Show resolved
Hide resolved
spanner/test/cloudexecutor/executor/internal/inputstream/handler.go
Outdated
Show resolved
Hide resolved
|
LGTM with small comments. |
https://fusion2.corp.google.com/invocations/679341f2-7708-4795-98bd-4ea9ebe46768/targets |
| texporter "github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace" | ||
| "go.opentelemetry.io/otel" | ||
| "go.opentelemetry.io/otel/propagation" | ||
| sdktrace "go.opentelemetry.io/otel/sdk/trace" |
There was a problem hiding this comment.
I am worried about this dep since we are adding a direct dependency of OTEL SDK package to the main package. This will download SDK dep to customer.
Can you check if we can have a seperate dependency file for executor which now relies on main package dependency. I have done something similar for opentelemetry tests since it also had SDK dependency.
https://github.com/googleapis/google-cloud-go/tree/main/spanner/test/opentelemetry/test
harshachinta
added
the
do not merge
…into systest-changes
…into systest-changes
…into systest-changes
|
@harshachinta can we help get this merged? |
This PR adds changes in spanner executor code required for testing end to end tracing feature.
Dependent on #10241