Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests #10213

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+86 −5
Open

fix(bigtable): Track number of readrows to set rowsLimit in subsequent requests #10213

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ab8b94a
test(bigtable): Use rowslimit in proxy
bhshkh May 16, 2024
cc7d220
test(bigtable): Limit rows only if specified by client
bhshkh May 16, 2024
cd50e9d
refactor(bigtable): Refactoring code
bhshkh May 16, 2024
1a21f06
Merge branch 'main' into test/cbt-proxy-rowslimit
bhshkh Dec 11, 2024
26cd101
Merge branch 'main' into test/cbt-proxy-rowslimit
bhshkh Dec 11, 2024
0f7ac71
Merge branch 'main' into test/cbt-proxy-rowslimit
bhshkh Jan 13, 2025
bc08882
track rows read in the library instead of proxy
bhshkh Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions bigtable/internal/testproxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,20 +570,33 @@ func (s *goTestProxyServer) ReadRows(ctx context.Context, req *pb.ReadRowsReques
ctx, cancel := btc.timeout(ctx)
defer cancel()

var c int32
var rowsReadTillNow int64
var rowsPb []*btpb.Row
lim := req.GetCancelAfterRows()

limitRowsRead := false
rowsToRead := int64(0)
if rrq.RowsLimit != 0 {
limitRowsRead = true
rowsToRead = rrq.RowsLimit
}
if req.GetCancelAfterRows() != 0 {
limitRowsRead = true
rowsToRead = int64(req.GetCancelAfterRows())
}

// Client libray does not have a built-in way to limit the number of rows read in a call to Table.ReadRows().
bhshkh marked this conversation as resolved.
Show resolved Hide resolved
// The caller needs to keep track of any kind of limit externally and from within the callback function passed to ReadRows()
err = t.ReadRows(ctx, rs, func(r bigtable.Row) bool {

c++
if c == lim {
if limitRowsRead && rowsReadTillNow == rowsToRead {
return false
}
rpb, err := rowToProto(r)
if err != nil {
return false
}
rowsPb = append(rowsPb, rpb)
rowsReadTillNow++
return true
})

Expand Down
Loading