This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
WIP: Fix return values for low covariance matrices #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case `if numx == 0 or numy == 0:`, the number of returned objects by `compute_ccas` is 6 instead of 5. The change in 139 in should correct this. Also, in the consequent case `# if x_idxs or y_idxs is all false, return_dict has zero entries` in `get_cca_similarity`, there are several items missing in `return_dict`. The other changes fix this. Can someone confirm that this is correct?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case
if numx == 0 or numy == 0:, the number of returned objects bycompute_ccasis 6 instead of 5. The change in 139 in should correct this.Also, in the consequent case
# if x_idxs or y_idxs is all false, return_dict has zero entriesinget_cca_similarity, there are several items missing inreturn_dict. The other changes fix this.Can someone confirm that this is correct?