Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Update cca_core.py with correct numpy LinAlg error check #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pranav-Goel
Copy link

It seems when checking for numpy linalg error (usually thrown when SVD does not converge) in the robust_cca_similarity function, the exception should be np.linalg.LinAlg and not np.LinAlg

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants