Minor fix to avoid crash in getIndicesData

google · Jul 27, 2017 · 7a13c8d · 7a13c8d
1 parent 9f78848
commit 7a13c8d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/gapis/api/vulkan/draw_call_mesh.go b/gapis/api/vulkan/draw_call_mesh.go
@@ -166,6 +166,10 @@ func getIndicesData(ctx context.Context, s *api.State, boundIndexBuffer *BoundIn
 		start := offset + uint64(firstIndex)*sizeOfIndex
 		size := uint64(indexCount) * sizeOfIndex
 		end := start + size
+		if start >= backingMem.Data.count || end > backingMem.Data.count {
+			log.E(ctx, "Shadow memory of index buffer is not big enough")
+			return []uint32{}
+		}
 		indicesSlice := backingMem.Data.Slice(start, end, s.MemoryLayout)
 		for i := uint64(0); (i < size) && (i+sizeOfIndex-1 < size); i += sizeOfIndex {
 			index := int32(0)