Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavefont: removing latin subsets #6865

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Wavefont: removing latin subsets #6865

merged 1 commit into from
Oct 17, 2023

Conversation

RosaWagner
Copy link
Contributor

Because subsetting would be disabled for that font.

@github-actions
Copy link

FontBakery report

fontbakery version: 0.10.1

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO From a total of 1 font files, 0 of them (0.00%) lack a STAT table.

    And these are the most common STAT axis orderings:
    ('ROND-YELA-wght', 1) [code: summary]


[24] Wavefont[ROND,YELA,wght].ttf
💔 ERROR: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
  • 💔 ERROR Failed with TypeError: 'NoneType' object is not subscriptable
🔥 FAIL: METADATA.pb should contain at least "menu" and "latin" subsets. (com.google.fonts/check/metadata/menu_and_latin)
  • 🔥 FAIL Subsets "menu" and "latin" are mandatory, but METADATA.pb is missing "latin". [code: missing]
🔥 FAIL: Check METADATA.pb includes production subsets. (com.google.fonts/check/metadata/includes_production_subsets)
  • 🔥 FAIL The following subsets are missing [latin, latin-ext] [code: missing-subsets]
🔥 FAIL: METADATA.pb font.name field contains font name in right format? (com.google.fonts/check/metadata/valid_name_values)
  • 🔥 FAIL METADATA.pb font.name field ("Wavefont") does not match correct font name format ("Wavefont Thin"). [code: mismatch]
🔥 FAIL: Check a font's STAT table contains compulsory Axis Values. (com.google.fonts/check/STAT)
  • 🔥 FAIL Compulsory STAT Axis Values are incorrect:
Name Axis Current Value Current Flags Current LinkedValue Expected Value Expected Flags Expected LinkedValue
Thin wght 100.0 0 None 100.0 0 None
ExtraLight wght 200.0 0 None 200.0 0 None
Light wght 300.0 0 None 300.0 0 None
Regular wght 400.0 2 700.0 400.0 2 700.0
Medium wght 500.0 0 None 500.0 0 None
SemiBold wght 600.0 0 None 600.0 0 None
Bold wght 700.0 0 None 700.0 0 None
ExtraBold wght 800.0 0 None 800.0 0 None
Black wght 900.0 0 None 900.0 0 None
ExtraBlack wght 1000.0 0 None N/A N/A N/A
[code: bad-axis-values]
🔥 FAIL: Validate defaults on fvar table match registered fallback names in GFAxisRegistry. (com.google.fonts/check/gf_axisregistry/fvar_axis_defaults)
  • 🔥 FAIL The defaul value ROND:100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
  • 🔥 FAIL The defaul value YELA:-100.0 is not registered as an axis fallback name on the Google Axis Registry.
    You should consider suggesting the addition of this value to the registry or adopted one of the existing fallback names for this axis:
    [name: "Default"
    value: 0.0
    ] [code: not-registered]
🔥 FAIL: Validate STAT particle names and values match the fallback names in GFAxisRegistry. (com.google.fonts/check/STAT/gf_axisregistry)
  • 🔥 FAIL Axis Value for 'ROND':'Default' is expected to be '0.0' but this font has 'Default'='100.0'. [code: bad-coordinate]
  • 🔥 FAIL Axis Value for 'YELA':'Default' is expected to be '0.0' but this font has 'Default'='-100.0'. [code: bad-coordinate]
  • 🔥 FAIL On the font variation axis 'wght', the name 'ExtraBlack' is not among the expected ones (Thin, ExtraLight, Light, Regular, Medium, SemiBold, Bold, ExtraBold, Black) according to the Google Fonts Axis Registry. [code: invalid-name]
🔥 FAIL: Checking OS/2 usWinAscent & usWinDescent. (com.google.fonts/check/family/win_ascent_and_descent)
  • 🔥 FAIL OS/2.usWinAscent value should be equal or greater than 1270, but got 1200 instead [code: ascent]
  • 🔥 FAIL OS/2.usWinDescent value 200 is too large. It should be less than double the yMin. Current absolute yMin value is 15 [code: descent]
🔥 FAIL: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
  • 🔥 FAIL The '.notdef' glyph should contain a drawing, but it is blank. [code: notdef-is-blank]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0009 : try adding symbols

  • U+000A : try adding symbols

  • U+000B : try adding symbols

  • U+000C : try adding symbols

  • U+0085 : try adding symbols

  • U+0100 LATIN CAPITAL LETTER A WITH MACRON: try adding latin-ext

  • U+0101 LATIN SMALL LETTER A WITH MACRON: try adding latin-ext

  • U+0102 LATIN CAPITAL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese

  • U+0103 LATIN SMALL LETTER A WITH BREVE: try adding one of: latin-ext, vietnamese

  • U+0104 LATIN CAPITAL LETTER A WITH OGONEK: try adding latin-ext
    189 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: menu [code: unreachable-subsetting]

WARN: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
  • WARN This variable font does not have an avar table. [code: missing-avar]
WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • cap
      [code: unreachable-glyphs]
WARN: Detect any interpolation issues in the font. (com.google.fonts/check/interpolation_issues)
  • WARN Interpolation issues were found in the font:

    • Contour order differs in glyph '_16': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b9a50>, [1, 2, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b8370>.

    • Contour 0 start point differs in glyph '_16' between location ROND=100,YELA=-100,wght=100 and location ROND=100,YELA=-100,wght=1000

    • Contour order differs in glyph '_31': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b9a50>, [2, 1, 0] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b8370>.

    • Contour 0 start point differs in glyph '_16.clip' between location ROND=100,YELA=-100,wght=100 and location ROND=0,YELA=-100,wght=100

    • Contour 0 start point differs in glyph '_16.clip' between location ROND=100,YELA=-100,wght=100 and location ROND=100,YELA=-100,wght=1000

    • Contour 0 start point differs in glyph '_16.clip' between location ROND=100,YELA=-100,wght=100 and location ROND=0,YELA=-100,wght=1000

    • Contour order differs in glyph '_1': [0, 1, 2] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b9a50>, [0, 2, 1] in <fontTools.ttLib.ttGlyphSet._TTGlyphSetGlyf object at 0x7fb3cc3b8040>.

    • Contour 0 start point differs in glyph '_1' between location ROND=100,YELA=-100,wght=100 and location ROND=0,YELA=-100,wght=100

    • Contour 0 start point differs in glyph '_1' between location ROND=100,YELA=-100,wght=100 and location ROND=100,YELA=-100,wght=4

    • Contour 0 start point differs in glyph '_1' between location ROND=100,YELA=-100,wght=100 and location ROND=0,YELA=-100,wght=4

    • 150 more.

Use -F or --full-lists to disable shortening of long lists. [code: interpolation-issues]

WARN: Check accent of Lcaron, dcaron, lcaron, tcaron (derived from com.google.fonts/check/alt_caron) (com.google.fonts/check/alt_caron)
  • WARN _15 is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN _61 is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN _62 is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
  • WARN _101 is decomposed and therefore could not be checked. Please check manually. [code: decomposed-outline]
WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/wavefont/Wavefont[ROND,YELA,wght].ttf
Dehinted Size 93.1kb
Hinted Size 93.1kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
  • INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 3.005;gftools[0.9.33]'] [code: version-not-detected]
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
  • INFO Version string is: "Version 3.005;gftools[0.9.33]"
    The version string must ideally include a git commit hash and either a "dev" or a "release" suffix such as in the example below:
    "Version 1.3; git-0d08353-release" [code: bad-format]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • loca

    • prep

    • BASE

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/wavefont [code: family-path]

Summary

💔 ERROR 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
1 8 7 49 9 178 0
0% 3% 3% 19% 4% 71% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@RosaWagner RosaWagner merged commit 25358d8 into main Oct 17, 2023
9 checks passed
@RosaWagner RosaWagner deleted the wavefont-subsets branch October 17, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant