Noto Sans Glagolitic: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added #6764
Conversation
FontBakery reportfontbakery version: 0.9.2 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[14] NotoSansGlagolitic-Regular.ttf🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
Use -F or --full-lists to disable shortening of long lists. [code: unattached-dotted-circle-marks] ⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: i̅ i҄ i҇ i꙯ i̦̅ i̦҄ i̦҇ i̦꙯ i̧̅ i̧҄ i̧҇ i̧꙯ j̅ j҄ j҇ j꙯ j̦̅ j̦҄ j̦҇ j̦꙯ Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers). Your font does not cover the following languages that require the soft-dotted feature: Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Navajo (Latn, 166,319 speakers), Belarusian (Cyrl, 10,064,517 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
|
|
@simoncozens The release notes say this update adds a dotted circle, but there is still one dotted circle related FontBakery fail. Should this be fixed, or can it be ignored? 🔥 FAIL: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle) |
|
This one is an issue, as the font does have mark glyphs. I'll check it out. |
There was a problem hiding this comment.
@simoncozens Looks good to me. The one FontBakery fail just needs to be addressed (should we ignore it, or fix it?), and then this can be merged.
…v1.8.4.7-5d5b) added * Noto Sans Glagolitic Version 2.004; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/notofonts/glagolitic.git at commit https://github.com/notofonts/glagolitic/commit/.
|
Updated Noto Sans Glagolitic: Version 2.004; ttfautohint (v1.8.4.7-5d5b) addedb8825b1: [gftools-packager] Noto Sans Glagolitic: Version 2.004; ttfautohint (v1.8.4.7-5d5b) added
|
simoncozens
force-pushed
the
gftools_packager_ofl_notosansglagolitic
branch
from
843301a to
b8825b1
Compare
FontBakery reportfontbakery version: 0.10.3 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[13] NotoSansGlagolitic-Regular.ttf🔥 FAIL: Check that legacy accents aren't used in composite glyphs. (derived from com.google.fonts/check/legacy_accents) (com.google.fonts/check/legacy_accents)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: On a family update, the DESCRIPTION.en_us.html file should ideally also be updated. (com.google.fonts/check/description/family_update)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours: [code: contour-count] ⚠ WARN: Check math signs have the same width. (com.google.fonts/check/math_signs_width)
Width = 322: ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: i̅ i҄ i҇ i꙯ i̦̅ i̦҄ i̦҇ i̦꙯ i̧̅ i̧҄ i̧҇ i̧꙯ j̅ j҄ j҇ j꙯ j̦̅ j̦҄ j̦҇ j̦꙯ Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Koonzime (Latn, 40,000 speakers), Nateni (Latn, 100,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ebira (Latn, 2,200,000 speakers), Aghem (Latn, 38,843 speakers), Igbo (Latn, 27,823,640 speakers), Ejagham (Latn, 120,000 speakers), Ma’di (Latn, 584,000 speakers), Kom (Latn, 360,685 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dan (Latn, 1,099,244 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Avokaya (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers). [code: soft-dotted] ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
|
@simoncozens tilde is off since previous version (not a regression). 
|
eliheuer
changed the title
There was a problem hiding this comment.
This looks good to me!
For the two FontBakery fails:
🔥 FAIL: Shapes languages in all GF glyphsets:
This is an experimental check with known issue and can be ignored
🔥 FAIL: Check that legacy accents aren't used in composite glyphs:
There are other Noto PRs with this fail that have been merged recently, so I assume it is ok, would be nice to have a rationale, but not necessary. For example:
#6867
#6779
The issues with mark alignment should be fixed, but I'm not saying it is a blocker because the issues existed in the previous font. I would prefer if these issues were fixed before merging though.
Thanks!
|
@simoncozens I have approved this pull request, but there are more mark alignment issues not shown in Rosalie's image above, for example: Before: Is it possible for you to fix the mark alignment issues before we merge this? Everything else looks good. Thanks! |
|
@simoncozens @RosaWagner What do we think, should we fix the issues here or just merge it? I could go either way. |
|
This won't be fixed easily. Glagolitic uses the combining tilde, and we have anchored it in a certain way; when the Noto Sans glyphs get merged in, the UFO merger sees the existing Either way a lot of work for minimal gain. The companion Latin on these fonts is not intended for general use anyway. |
843301a: [gftools-packager] Noto Sans Glagolitic: Version 2.003; ttfautohint (v1.8.4.7-5d5b) added