Add TODOs to fix this-before-super problems.

We're trying to migrate all ES5 subclasses of Closure Library to ES6. In ES6 this cannot be referenced before super is called. These files cannot be automatically upgraded to ES6 as a result. If you have the time please fix these for us and remove the TODO. We'd greatly appreciate it. More information: go/lsc-closure-es5-subclasses-to-es6 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=246907173
google · May 6, 2019 · 97390e9 · 97390e9
1 parent e1a8bc3
commit 97390e9
Show file tree

Hide file tree

Showing 18 changed files with 162 additions and 0 deletions.
diff --git a/closure/goog/db/error.js b/closure/goog/db/error.js
@@ -18,6 +18,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.db.DomErrorLike');
 goog.provide('goog.db.Error');
 goog.provide('goog.db.Error.ErrorCode');

diff --git a/closure/goog/debug/fancywindow.js b/closure/goog/debug/fancywindow.js
@@ -24,6 +24,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.debug.FancyWindow');
 
 goog.require('goog.array');

diff --git a/closure/goog/demos/editor/helloworlddialog.js b/closure/goog/demos/editor/helloworlddialog.js
@@ -17,6 +17,15 @@
  *
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.demos.editor.HelloWorldDialog');
 goog.provide('goog.demos.editor.HelloWorldDialog.OkEvent');
 

diff --git a/closure/goog/dom/controlrange.js b/closure/goog/dom/controlrange.js
@@ -20,6 +20,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.dom.ControlRange');
 goog.provide('goog.dom.ControlRangeIterator');
 

diff --git a/closure/goog/dom/multirange.js b/closure/goog/dom/multirange.js
@@ -19,6 +19,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.dom.MultiRange');
 goog.provide('goog.dom.MultiRangeIterator');
 

diff --git a/closure/goog/dom/pattern/childmatches.js b/closure/goog/dom/pattern/childmatches.js
@@ -19,6 +19,15 @@
  * @author [email protected] (Robby Walker)
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.dom.pattern.ChildMatches');
 
 goog.require('goog.dom.pattern.AllChildren');

diff --git a/closure/goog/dom/pattern/fulltag.js b/closure/goog/dom/pattern/fulltag.js
@@ -18,6 +18,15 @@
  * @author [email protected] (Robby Walker)
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.dom.pattern.FullTag');
 
 goog.require('goog.dom.pattern.MatchType');

diff --git a/closure/goog/dom/textrangeiterator.js b/closure/goog/dom/textrangeiterator.js
@@ -18,6 +18,15 @@
  * @author [email protected] (Robby Walker)
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.dom.TextRangeIterator');
 
 goog.require('goog.array');

diff --git a/closure/goog/fs/error.js b/closure/goog/fs/error.js
@@ -17,6 +17,15 @@
  *
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.fs.DOMErrorLike');
 goog.provide('goog.fs.Error');
 goog.provide('goog.fs.Error.ErrorCode');

diff --git a/closure/goog/graphics/ext/graphics.js b/closure/goog/graphics/ext/graphics.js
@@ -19,6 +19,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.graphics.ext.Graphics');
 
 goog.require('goog.events');

diff --git a/closure/goog/graphics/ext/shape.js b/closure/goog/graphics/ext/shape.js
@@ -19,6 +19,15 @@
  */
 
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.graphics.ext.Shape');
 
 goog.require('goog.graphics.ext.StrokeAndFillElement');

diff --git a/closure/goog/graphics/vmlelement.js b/closure/goog/graphics/vmlelement.js
@@ -19,6 +19,15 @@
  * @author [email protected] (Erik Arvidsson)
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.graphics.VmlEllipseElement');
 goog.provide('goog.graphics.VmlGroupElement');
 goog.provide('goog.graphics.VmlImageElement');

diff --git a/closure/goog/labs/format/csv.js b/closure/goog/labs/format/csv.js
@@ -22,6 +22,15 @@
  *
  * @author [email protected] (Nathan Naze) Ported to Closure
  */
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.labs.format.csv');
 goog.provide('goog.labs.format.csv.ParseError');
 goog.provide('goog.labs.format.csv.Token');

diff --git a/closure/goog/net/ipaddress.js b/closure/goog/net/ipaddress.js
@@ -19,6 +19,15 @@
  *
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.net.IpAddress');
 goog.provide('goog.net.Ipv4Address');
 goog.provide('goog.net.Ipv6Address');

diff --git a/closure/goog/storage/mechanism/ieuserdata.js b/closure/goog/storage/mechanism/ieuserdata.js
@@ -20,6 +20,15 @@
  *
  */
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.storage.mechanism.IEUserData');
 
 goog.require('goog.asserts');

diff --git a/closure/goog/testing/fs/entry.js b/closure/goog/testing/fs/entry.js
@@ -19,6 +19,15 @@
  */
 
 goog.setTestOnly('goog.testing.fs.DirectoryEntry');
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.testing.fs.DirectoryEntry');
 goog.provide('goog.testing.fs.Entry');
 goog.provide('goog.testing.fs.FileEntry');

diff --git a/closure/goog/testing/net/xhriopool.js b/closure/goog/testing/net/xhriopool.js
@@ -18,6 +18,15 @@
  */
 
 goog.setTestOnly('goog.testing.net.XhrIoPool');
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.testing.net.XhrIoPool');
 
 goog.require('goog.net.XhrIoPool');

diff --git a/closure/goog/ui/sliderbase_test.js b/closure/goog/ui/sliderbase_test.js
@@ -12,6 +12,15 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+
+// TODO(b/130421259): We're trying to migrate all ES5 subclasses of Closure
+// Library to ES6. In ES6 this cannot be referenced before super is called. This
+// file has at least one this before a super call (in ES5) and cannot be
+// automatically upgraded to ES6 as a result. Please fix this if you have a
+// chance. Note: This can sometimes be caused by not calling the super
+// constructor at all. You can run the conversion tool yourself to see what it
+// does on this file: blaze run //javascript/refactoring/es6_classes:convert.
+
 goog.provide('goog.ui.SliderBaseTest');
 goog.setTestOnly('goog.ui.SliderBaseTest');