This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
Aligned the "Minute" members of intraday and historical data points. #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They appear to both be used the same way, as a string field that tells
us the minute of the data point in the time zone of the exchange.
I also removed a helper function that attempts to get the time from the
historical data point by combining the date and minute fields. The
problem is that this results in the wrong time because the time objects
are in UTC, so to do this right you'd need to know the time zone which
the "minute" value is in. I think we should leave it up to the consumer
to write their methods to convert times according to their special
circumstances.