Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User subcommand #289

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Standing-Man
Copy link
Contributor

Add additional subcommand for user command

  • harbor user reset [username] -> for reset the user's password
  • harbor user update [username] -> for update the user's profile

@Standing-Man
Copy link
Contributor Author

Hi @Vad1mo, I’ve added two additional subcommands under user and wanted to check if it would be helpful to include a subcommand for setting a user’s role to Administrator or revoking the Administrator role.

@bupd
Copy link
Member

bupd commented Dec 28, 2024

@Standing-Man Thanks for your contributions.

cmd/harbor/root/user/reset.go Outdated Show resolved Hide resolved
cmd/harbor/root/user/reset.go Outdated Show resolved Hide resolved
cmd/harbor/root/user/update.go Outdated Show resolved Hide resolved
cmd/harbor/root/user/update.go Outdated Show resolved Hide resolved
cmd/harbor/root/user/update.go Show resolved Hide resolved
pkg/api/user_handler.go Outdated Show resolved Hide resolved
pkg/api/user_handler.go Outdated Show resolved Hide resolved
@Standing-Man
Copy link
Contributor Author

enhance :

  • add --userID flag on update subcommand
  • fix the error handler of api.GetUsersIdByName
  • supplement the descriptions for reset and update
  • maintain log messages consistently

@Standing-Man Standing-Man requested a review from bupd December 28, 2024 05:11
@bupd
Copy link
Member

bupd commented Dec 29, 2024

@Standing-Man for the suggestions that are added mark the conversations as resolved.
Thanks

@Standing-Man
Copy link
Contributor Author

Thank you for your reminder @bupd. I have marked these conversations as resolved.

@Standing-Man
Copy link
Contributor Author

Hi @Vad1mo and @bupd, ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants