Added DNF type support

src/Aop/Pointcut/AndPointcut.php

@@ -39,8 +39,20 @@
     /**
      * And constructor
      */
-    public function __construct(int $pointcutKind = null, Pointcut ...$pointcuts)
+    public function __construct(int $pointcutKind = null)
     {
+        $args = func_get_args();
+
+        if (is_array($args[1])) {
+            $pointcuts = $args[1];
+        } else {
+            $pointcuts = array_slice($args, 1);
+        }
+
+        if (count(array_filter($pointcuts, static fn ($pointcut) => $pointcut instanceof Pointcut)) !== count($pointcuts)) {
+            throw new \Exception('only pointcats allowed to be passed');
+        }
+
         // If we don't have specified kind, it will be calculated as intersection then
         if (!isset($pointcutKind)) {
             $pointcutKind = -1;

src/Aop/Pointcut/ClassInheritancePointcut.php

@@ -13,6 +13,9 @@
 namespace Go\Aop\Pointcut;
 
 use Go\Aop\Pointcut;
+use Go\Aop\Pointcut\DNF\Parser\TokenizerParserInterface;
+use Go\Aop\Pointcut\DNF\SemanticAnalyzerInterface;
+use Go\Core\AspectKernel;
 use Go\ParserReflection\ReflectionFileNamespace;
 use ReflectionClass;
 use ReflectionFunction;
@@ -25,11 +28,25 @@
  */
 final readonly class ClassInheritancePointcut implements Pointcut
 {
+    private const DNF_TOKENS = ['(', ')', '&', '|'];
+
+    private TokenizerParserInterface $tokenizerParser;
+    private SemanticAnalyzerInterface $semanticAnalyzer;
+
     /**
      * Inheritance class matcher constructor
+     *
      * @param (string&class-string) $parentClassOrInterfaceName Parent class or interface name to match in hierarchy
      */
-    public function __construct(private string $parentClassOrInterfaceName) {}
+    public function __construct(private string $parentClassOrInterfaceName)
+    {
+        $this->tokenizerParser = AspectKernel::getInstance()->getContainer()->getService(
+            TokenizerParserInterface::class
+        );
+        $this->semanticAnalyzer = AspectKernel::getInstance()->getContainer()->getService(
+            SemanticAnalyzerInterface::class
+        );
+    }
 
     public function matches(
         ReflectionClass|ReflectionFileNamespace                $context,
@@ -42,12 +59,27 @@ public function matches(
             return false;
         }
 
-        // Otherwise, we match only if given context is child of given previously class name (either interface or class)
-        return $context->isSubclassOf($this->parentClassOrInterfaceName) || in_array($this->parentClassOrInterfaceName, $context->getInterfaceNames());
+        if (!$this->isDNFType()) {
+            // Otherwise, we match only if given context is child of given previously class name (either interface or class)
+            return $context->isSubclassOf($this->parentClassOrInterfaceName) || in_array($this->parentClassOrInterfaceName, $context->getInterfaceNames());
+        }
+
+        return $this->checkDNFType($context);
     }
 
     public function getKind(): int
     {
         return self::KIND_CLASS;
     }
+
+    private function isDNFType(): bool
+    {
+        return array_intersect(str_split($this->parentClassOrInterfaceName), self::DNF_TOKENS) !== [];
+    }
+
+    private function checkDNFType(ReflectionClass|ReflectionFileNamespace $context): bool
+    {
+        $ast = $this->tokenizerParser->parse($this->parentClassOrInterfaceName);
+        return $this->semanticAnalyzer->verifyTree($ast, $context);
+    }
 }

src/Aop/Pointcut/DNF/AST/Node.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\AST;
+
+readonly class Node
+{
+    public function __construct(
+        public NodeType $type,
+        public ?string $identifier = null,
+        public ?Node $left = null,
+        public ?Node $right = null,
+    ) {
+    }
+}

src/Aop/Pointcut/DNF/AST/NodeType.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\AST;
+
+enum NodeType
+{
+    case IDENTIFIER;
+    case AND;
+    case OR;
+}

src/Aop/Pointcut/DNF/Parser/Token.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\Parser;
+
+enum Token
+{
+    case EOF;
+    case IDENTIFIER;
+    case LPAREN;
+    case RPAREN;
+    case AND;
+    case OR;
+}

src/Aop/Pointcut/DNF/Parser/TokenCollection.php

@@ -0,0 +1,74 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\Parser;
+class TokenCollection implements TokenCollectionInterface
+{
+    /**
+     * @param \ArrayIterator<\PhpToken> $tokens
+     */
+    public function __construct(
+        private readonly \ArrayIterator $tokens
+    ) {
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function expect(Token $token): void
+    {
+        /** @var Token $nextToken */
+        [$nextToken] = $this->next();
+
+        if ($nextToken !== $token) {
+            throw new \Exception(sprintf('Expected %s, but got %s', $token->name, $nextToken->name));
+        }
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function next(): array
+    {
+        if (! $this->tokens->valid()) {
+            return [Token::EOF, null];
+        }
+
+        $val = trim($this->tokens->current()->text);
+
+        if ($val === '') {
+            return $this->next();
+        }
+
+        $return = [$this->getToken($val), $val];
+        $this->tokens->next();
+
+        return $return;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function peek(int $i): array
+    {
+        $offset = $this->tokens->key() + $i;
+        if (! $this->tokens->offsetExists($offset)) {
+            return [Token::EOF, null];
+        }
+
+        $val = trim($this->tokens->offsetGet($offset)->text);
+
+        return [$this->getToken($val), $val];
+    }
+
+    private function getToken(string $val): Token
+    {
+        return match ($val) {
+            chr(26) => Token::EOF,
+            '(' => Token::LPAREN,
+            ')' => Token::RPAREN,
+            '|' => Token::OR,
+            '&' => Token::AND,
+            default => Token::IDENTIFIER
+        };
+    }
+}

src/Aop/Pointcut/DNF/Parser/TokenCollectionInterface.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\Parser;
+
+interface TokenCollectionInterface
+{
+    /**
+     * @throws \Exception
+     */
+    public function expect(Token $token): void;
+
+    /**
+     * @return array{0: Token, 1: string|null}
+     */
+    public function next(): array;
+
+    /**
+     * @return array{0: Token, 1: string|null}
+     */
+    public function peek(int $i): array;
+}

src/Aop/Pointcut/DNF/Parser/TokenizerParser.php

@@ -0,0 +1,113 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\Parser;
+
+use Exception;
+use Go\Aop\Pointcut\DNF\AST\Node;
+use Go\Aop\Pointcut\DNF\AST\NodeType;
+use PhpToken;
+
+class TokenizerParser implements TokenizerParserInterface
+{
+    public function parse(string $input): Node
+    {
+        return $this->parseExpression($this->tokenize($input));
+    }
+
+    private function tokenize(string $input): TokenCollection
+    {
+        $input = sprintf('<?php %s%s', $input, chr(/* EOF */26));
+        $tokens = new \ArrayIterator(PhpToken::tokenize($input));
+        $arrayIntersect = array_intersect(
+            (array)$tokens,
+            ['string', 'bool', 'array', 'float', 'int', 'integer', 'null', 'resource']
+        );
+        if ($arrayIntersect !== []) {
+            throw new Exception(sprintf('Tokens [%s] not allowed', implode(', ', $arrayIntersect)));
+        }
+
+        $tokens = new TokenCollection($tokens);
+        //skip '<?php'
+        $tokens->next();
+
+        return $tokens;
+    }
+
+    private function parseSubExpression(
+        TokenCollection $tokens,
+        int $bindingPower,
+        bool $insideParenthesis = false
+    ): ?Node {
+        [$token, $val] = $tokens->next();
+        switch ($token) {
+            case Token::LPAREN:
+                $left = $this->parseSubexpression($tokens, 0, true);
+                $tokens->expect(Token::RPAREN);
+                break;
+            case Token::IDENTIFIER:
+                $left = new Node(NodeType::IDENTIFIER, $val);
+                break;
+            default:
+                throw new Exception('Bad Token');
+        }
+
+        while (true) {
+            [$token] = $tokens->peek(0);
+
+            if ($token === Token::OR && $insideParenthesis) {
+                throw new \Exception('Only intersections allowed in the group');
+            }
+
+            switch ($token) {
+                case Token::OR:
+                case Token::AND:
+                    [$leftBP, $rightBP] = $this->getBindingPower($token);
+                    if ($leftBP < $bindingPower) {
+                        break 2;
+                    }
+                    $tokens->next();
+                    $right = $this->parseSubexpression($tokens, $rightBP, $insideParenthesis);
+                    $left = $this->operatorNode($token, $left, $right);
+                    break;
+                case Token::RPAREN:
+                case Token::EOF:
+                default:
+                    break 2;
+            }
+        }
+
+        return $left;
+    }
+
+    private function parseExpression(TokenCollection $tokens): ?Node
+    {
+        $sub = $this->parseSubExpression($tokens, 0);
+        $tokens->expect(Token::EOF);
+
+        return $sub;
+    }
+
+    private function operatorNode(Token $type, Node $left, ?Node $right): Node
+    {
+        return match ($type) {
+            Token::OR => new Node(NodeType::OR, left: $left, right: $right),
+            Token::AND => new Node(NodeType::AND, left: $left, right: $right),
+            default => throw new Exception('invalid op')
+        };
+    }
+
+    /**
+     * @param Token $type
+     *
+     * @return array{0: int, 1: int}
+     */
+    private function getBindingPower(Token $type): array
+    {
+        return match ($type) {
+            Token::OR => [1, 2],
+            Token::AND => [3, 4],
+            default => throw new Exception('Invalid operator')
+        };
+    }
+
+}

src/Aop/Pointcut/DNF/Parser/TokenizerParserInterface.php

@@ -0,0 +1,8 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF\Parser;
+
+interface TokenizerParserInterface
+{
+    public function parse(string $input);
+}

src/Aop/Pointcut/DNF/SemanticAnalyzer.php

@@ -0,0 +1,44 @@
+<?php
+
+namespace Go\Aop\Pointcut\DNF;
+
+use Go\Aop\Pointcut\DNF\AST\Node;
+use Go\Aop\Pointcut\DNF\AST\NodeType;
+use Go\ParserReflection\ReflectionFileNamespace;
+
+class SemanticAnalyzer implements SemanticAnalyzerInterface
+{
+    public function verifyTree(?Node $tree, \ReflectionClass|ReflectionFileNamespace $val)
+    {
+        if ($tree !== null && $tree->type === NodeType::IDENTIFIER && $tree->identifier !== null) {
+            $parentClasses = $this->getParentClasses($val);
+
+            return in_array($tree->identifier, $parentClasses, true)
+                || $val->implementsInterface($tree->identifier);
+        }
+
+        if ($tree?->type === NodeType::AND) {
+            return $this->verifyTree($tree->left, $val) && $this->verifyTree($tree->right, $val);
+        }
+
+        if ($tree->type === NodeType::OR) {
+            return $this->verifyTree($tree->left, $val) || $this->verifyTree($tree->right, $val);
+        }
+    }
+
+    /**
+     * @param ReflectionFileNamespace|\ReflectionClass $val
+     *
+     * @return array
+     */
+    public function getParentClasses(ReflectionFileNamespace|\ReflectionClass $val): array
+    {
+        $parentClasses = [];
+        while ($val->getParentClass()) {
+            $parentClasses[] = $val->getParentClass()->getName();
+            $val = $val->getParentClass();
+        }
+
+        return $parentClasses;
+    }
+}