feat/manage protocol fee list #464
Open
+408
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlyhyde
requested changes
Jan 18, 2025
| balance := common.BalanceOf(token, consts.PROTOCOL_FEE_ADDR) | ||
|
|
||
| // amount in `tokenListWithAmount` is corrupted, it should be equal to balance | ||
| if amount != balance { |
There was a problem hiding this comment.
Anyone can transfer assets to a PROTOCOL_FEE contract. The guard on that line is panicking if the assets on the books don't match the balance in the actual token contract. If someone maliciously sends assets to the PROTOCOL_FEE Contract, PROTOCOL_FEE will never receive them back. We recommend removing the guard on that line as it can cause problems.
| panic(errInvalidAmount.Error()) | ||
| } | ||
|
|
||
| if balance > 0 { |
There was a problem hiding this comment.
It looks like the condition should enter when the amount, not balance, is greater than or equal to 0.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
protocol_feemanages accumulated token path with its amount