-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(staker): reward calculation warmup #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can you add one more test case with multiple warm-up conditions? Reward and penalty should be calculated separately for each warm-up period. I suggest two cases:
- When a position is staked for 5 days of blocks + 1 block, then
WarmupRatio30
should be applied for 5 days of blocks , andWarmupRatio50
for the last one block. - When a position is staked for 40 days, then
WarmupRatio30
for 0-5 days of blocks,WarmupRatio50
for 6-10 days of blocks,WarmupRatio70
for 11-30 days of blocks,WarmupRatio100
, aka full rewards, for 31-40 days of blocks.
Quality Gate passedIssues Measures |
@dongwon8247 added 1d82231 |
Description
1. Warmup Template Validation
2. Reward Calculation Precision
3. Liquidity Ratio Tests
4. Warmup Stage Transitions
5. Edge Cases