Fix panic caused by division by zero #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkgnosis
approved these changes
Nov 22, 2022
|
If I understand the code correctly, it converts absolute slippage into relative slippage and returns the minimum between this computed relative slippage and the relative slippage from another part of the code. As the zero case means that relative slippage from absolute slippage is infinity, maybe it would be better to just return the relative slippage at this point? |
|
Is this a fix for #37? |
|
Why is it trying to compute the slippage for a 0 amount though 🤔. Anyway, the fix looks correct to me, although it may be the symptom of a different bug/problem. |
nlordell
approved these changes
Nov 22, 2022
bh2smith
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes panics caused by dividing by zero in the slippage calculation.