-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor preview environment and image build methods #19652
Conversation
0e6249f
to
f8c9a6a
Compare
f8c9a6a
to
bb3e116
Compare
3ec58ea
to
3b94ea1
Compare
545292a
to
f77915a
Compare
|
Tested with preview env that it will build extension codeWebExtensionCommit: 736db6fb669a1e3dd3379c26e1aa932ab9c8f696
xtermCommit: 5a2eb92bec3dda821201f2681f531d1134173e6c
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
/unhold |
diff-apply "${PREVIEW_K3S_KUBE_CONTEXT}" stripe-api-keys.secret.yaml | ||
rm -f stripe-api-keys.secret.yaml | ||
|
||
yq w -i "${INSTALLER_CONFIG_PATH}" "experimental.webapp.server.stripeSecret" "stripe-api-keys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR introduces significant refactoring to improve the security and efficiency of our deployment and build processes across the Gitpod infrastructure.
Key Changes
Preview Environment Create and Destroy:
Kubernetes Cluster and Secret Management:
core-dev
Kubernetes cluster by adopting Google Secret Manager for handling secrets more securely and efficiently.Build Process Refactoring:
gitpod-web-extension
and thexterm web IDE
. These are now built directly within the Gitpod repository rather than their respective repositories. Correspondingcommit ids
in theWORKSPACE.yaml
need updating to reflect these changes.Service Account Key Management:
fluent-bit
andgcr sa
, transitioning to VM service accounts that generate short-term tokens. This enhances security by reducing the attack surface associated with long-term credentials.Artifact Storage Location:
eu.gcr.io/gitpod-dev-artifact/build/
, while artifacts from the main branch continue to reside in the same location.These changes are aimed at hardening our supply chain by reducing dependencies and improving security across our development operations.
Related Issue(s)
Fixes ENG-1963
Fixes ENG-2079
Part of ENG-1950
Part of ENG-2037
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold