Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to disable -Wimplicit-fallthrough to complle (compiles, untested) #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/glb-director/shared_opt.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ void get_options(char *config_file, char *forwarding_table, int argc,
{"forwarding-table", required_argument, NULL, 't'},
{"debug", no_argument, NULL, 'v'},
{NULL, 0, NULL, 0}};
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"

while ((opt = getopt_long(argc, argv, ":c:t:v", long_options, NULL)) !=
-1)
Expand All @@ -73,6 +75,8 @@ void get_options(char *config_file, char *forwarding_table, int argc,
abort();
}

#pragma GCC diagnostic pop

glb_log_info("Using config: %s, Using forwarding table: %s,",
config_file, forwarding_table);

Expand Down
5 changes: 4 additions & 1 deletion src/glb-director/siphash24.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ int siphash(uint8_t *out, const uint8_t *in, uint64_t inlen, const uint8_t *k)

v0 ^= m;
}

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
switch (left) {
case 7:
b |= ((uint64_t)in[6]) << 48;
Expand All @@ -138,6 +139,8 @@ int siphash(uint8_t *out, const uint8_t *in, uint64_t inlen, const uint8_t *k)
break;
}

#pragma GCC diagnostic pop

v3 ^= b;

TRACE;
Expand Down