Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add MaD models for SysAllocString and friends #18463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MathiasVP
Copy link
Contributor

The lack of these models were causing some false negatives at Microsoft.

@Copilot Copilot bot review requested due to automatic review settings January 9, 2025 17:34
@MathiasVP MathiasVP requested a review from a team as a code owner January 9, 2025 17:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • cpp/ql/test/library-tests/dataflow/external-models/flow.expected: Language not supported
  • cpp/ql/test/library-tests/dataflow/taint-tests/localTaint.expected: Language not supported
  • cpp/ql/test/library-tests/dataflow/taint-tests/taint.cpp: Language not supported
  • cpp/ql/test/library-tests/dataflow/taint-tests/test_mad-signatures.expected: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the C++ label Jan 9, 2025
@MathiasVP MathiasVP added no-change-note-required This PR does not need a change note and removed no-change-note-required This PR does not need a change note labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant